Reinforcement_Learning icon indicating copy to clipboard operation
Reinforcement_Learning copied to clipboard

A problem in PPOAgent

Open sailxjx opened this issue 4 years ago • 0 comments

Hi, Rokas:

First of all thanks for your great tutorial on reinforcement learning, I went through all the series and learned a lot.

In the PPOAgent I think there may be something wrong with this line. When I vstack the discounted_r (shape of (n,1)) and subtract it with predicted values (shape of (n,)), the advantages become shape of (n,n). So I think maybe we should not vstack discounted_r, but vstack the advantages in this line advantages = np.vstack(discounted_r - values), then the advantages are shape of (n,1), which is the expected result.

Thanks.

sailxjx avatar Apr 28 '21 08:04 sailxjx