python-gssapi icon indicating copy to clipboard operation
python-gssapi copied to clipboard

really drop python<=3.7 support

Open kloczek opened this issue 1 year ago • 1 comments

Filter all code over pyupgracde --py38-plus.

kloczek avatar Oct 03 '24 05:10 kloczek

BTW end of this month 3.8 will be EOSed.

kloczek avatar Oct 03 '24 05:10 kloczek

This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.

github-actions[bot] avatar Nov 01 '24 01:11 github-actions[bot]

Any update? 🤔

kloczek avatar Nov 01 '24 05:11 kloczek

Sorry I didn't get to this earlier. I'm reluctant to merging in stylistic changes without having an actual check in CI to back it for future commits. Granted there are still some Python 2-isms still in there that this PR is fixing but making these changes doesn't really achieve to much in the long run.

If I was really wanting to do something like this I would prefer to just have something like black to go over the codebase.

jborean93 avatar Nov 11 '24 03:11 jborean93

black is the Python code formatter. pyupgrade replaces syntax to more effective handled by exact Python version (please read pyupgrade documentation for details). gssapi passes pytest test suite with this PR. Did you test this PR? 🤔

kloczek avatar Nov 13 '24 13:11 kloczek

This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.

github-actions[bot] avatar Sep 02 '25 01:09 github-actions[bot]