arcade icon indicating copy to clipboard operation
arcade copied to clipboard

Camera overhaul simple

Open DragonMoffon opened this issue 1 year ago • 3 comments
trafficstars

This PR includes an updated Orthographic Camera and Camera2D to replace the old SimpleCamera provided with <3.0 Arcade.

There is a more detailed Draft PR with extra components (#1905).

DragonMoffon avatar Feb 04 '24 12:02 DragonMoffon

Wow, ok, that are many modified files :/ There are also changes in non camera code files.

eruvanos avatar Feb 04 '24 18:02 eruvanos

Yeah, there were a bunch of files that used the old camera code that had to be changed. If any changes aren´t related to the camera, I will reverse them .

DragonMoffon avatar Feb 05 '24 00:02 DragonMoffon

My first read through only found a few spots with non-Camera changes. Most seemed to be opportunistic whitespace changes. The majority of the changes seemed to be in doc which uses cameras.

pushfoo avatar Feb 20 '24 05:02 pushfoo

Went through the hell fire and resolved all conflicts.

Some notes:

  • Platformer tutorial must have the camera applied again (it was completely changed. Even renamed)
  • The TextureAtlas did NOT like the camera in render_into, so I had to yank that out setting viewport and projection manually

Still need to go through the code in more detail and wrap my head around things.

einarf avatar Feb 24 '24 18:02 einarf

This PR also touching things not related to the camera itself. It would be better to move the spritelist changes into separate PR. I will yank that out for now since it conflicts with other plans. Taking in string arguments that translates into some internal magic behavior is something we want to avoid as much as possible. Instead we want the "renderpass" object thingy.

einarf avatar Feb 24 '24 18:02 einarf