typeshed icon indicating copy to clipboard operation
typeshed copied to clipboard

Checks don't run on stubsabot PRs

Open hauntsaninja opened this issue 3 years ago • 2 comments

However, you can trigger them by manually closing and re-opening.

This isn't an ideal state of things. There's a list of possible workarounds here: https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#workarounds-to-trigger-further-workflow-runs

hauntsaninja avatar Jul 29 '22 00:07 hauntsaninja

There's a list of possible workarounds here: https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#workarounds-to-trigger-further-workflow-runs

I like the sound of the last option on this list best: creating a minimal GitHub App that would generate tokens for use with GitHub Actions. The only downside I can see is that the app would have to be associated with a maintainer's personal account, so if the maintainer stopped being active for whatever reason, it might be difficult for other maintainers to get access to the app. I think it would still be better than the current state of affairs, however -- if others agree, I'm happy to set up a GitHub App to do this?

AlexWaygood avatar Sep 17 '22 18:09 AlexWaygood

Oh, actually, the ssh key option would maybe be better. I was worried that it wouldn't work so well, because of the fact that it only works with push events, rather than pull_request events. But that shouldn't be an issue: stubsabot creates new branches on the typeshed fork, and we can easily adjust the tests.yml workflow so that it runs on push events for any branches starting with stubsabot/. The ssh option is used by oddbird/MetaDeploy here, and they seem pretty happy about it (they wrote a nice blog post about their automated PRs for uprading dependencies here.)

AlexWaygood avatar Sep 17 '22 23:09 AlexWaygood