python-docs-theme icon indicating copy to clipboard operation
python-docs-theme copied to clipboard

Make copybutton messages translatable

Open ccwang002 opened this issue 6 years ago • 3 comments

This PR implements #23 which make the messages of copybutton (>>>) translatable.

When I tested my change using the master branch of Python (branch 3.7 doesn't seem to use python-docs-theme), I couldn't get it read my modified layout.html. However, if I manually introduced the change, the pot files would include the new strings and the translation worked.

I think it is better to have someone more familiar with the project structure of PEP 545 to test my implementation before it is merged.

ccwang002 avatar Feb 17 '19 22:02 ccwang002

There's a little issue, the command gathering translations strings:

sphinx-build -Q -b gettext -D gettext_compact=0 Doc pot/

won't pick it up, so translation teams won't see it as a sentence to translate. I don't have the time right now to check if there's a simple way to solve this, maybe Sphinx has a way to look for translations strings in configured theme?

JulienPalard avatar Feb 18 '19 13:02 JulienPalard

These resources might be helpful:

  1. https://github.com/rtfd/sphinx_rtd_theme/issues/403
  2. https://github.com/rtfd/sphinx_rtd_theme/pull/405

theacodes avatar Feb 19 '19 07:02 theacodes

I think I looked into this in the past and it was possible to directly translate the strings in the javascript file

septatrix avatar Jun 14 '20 09:06 septatrix