python-docs-theme icon indicating copy to clipboard operation
python-docs-theme copied to clipboard

Published 20 hours ago • verified publisher icon python

Dark theme: double magnifying glass on iOS

Open m-aciek opened this issue 2 years ago • 2 comments

Big thank you for the work on dark theme (https://github.com/python/python-docs-theme/pull/44), I love the changes. I found minor bug while testing the updated styles on different devices.

On iOS, in both Chrome and Safari there's double magnifier glass shown near to the search box.

iOS 16.3.1, (Chrome 111.0.5563.72) cc @septatrix

m-aciek avatar Mar 18 '23 22:03 m-aciek

It is probably one of the following pseudo elements, if I were to guess probably the first:

input[type="search"]::-webkit-search-decoration
input[type="search"]::-webkit-search-cancel-button
input[type="search"]::-webkit-search-results-button
input[type="search"]::-webkit-search-results-decoration

It should be possible to hide it by applying a display: none; to the respective element. Or we could remove the search icon added by ourselves (how it is currently in the desktop search bar) and leave safari alone. Depends on what most people prefer.

septatrix avatar Mar 21 '23 23:03 septatrix

My intuitional preference would be to just hide the browser-native icon to maintain the same interface across different machines.

m-aciek avatar Mar 22 '23 10:03 m-aciek