peps icon indicating copy to clipboard operation
peps copied to clipboard

Infra: Ignore certain commits when calculating the last modified date

Open AA-Turner opened this issue 2 years ago • 2 comments

Depends on #3431.

Due to #3418, all dates in the footers of PEPs report that the PEP was last modified on 9 September 2023. Whilst this was expected, and is superficially correct, we really want to report the last substantive modification time.

This uses the comprehensive list of ignored commits from #3431 to display the most recent substantive modification of each PEP, which is what readers would expect.

A


:books: Documentation preview :books:: https://pep-previews--3432.org.readthedocs.build/

AA-Turner avatar Sep 09 '23 20:09 AA-Turner

(Converting to draft as this should not be merged before #3431)

AA-Turner avatar Sep 09 '23 20:09 AA-Turner

Should "Last modified:" be renamed as "Last substantive modified:"? I don't think so.

You can mark edits on Wikipedia as "minor edits", but they still show up as "Last edited".

I'd just leave it as is, let "Last modified" reflect reality, and people who click it can see the history and decide for themselves what is important for them.

hugovk avatar Sep 14 '23 05:09 hugovk