cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-72496: Implemented patch to improve performance of string.Template

Open delta1513 opened this issue 3 years ago • 2 comments
trafficstars

Implemented the patchfile from BPO 28309

Fixes #72496

As also noted in the issue thread, I noticed no performance improvements on my machine so someone else may want to verify whether these changes are actually beneficial.

  • Issue: gh-72496

delta1513 avatar Nov 07 '22 01:11 delta1513

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

bedevere-bot avatar Nov 07 '22 01:11 bedevere-bot

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:
CLA not signed

cpython-cla-bot[bot] avatar Nov 07 '22 01:11 cpython-cla-bot[bot]

LGTM. @delta1513 Can you sign the the CLA and add a NEWS entry?

furkanonder avatar Feb 01 '23 10:02 furkanonder

@furkanonder I just realized that my old account @delta1512 (which I have been locked-out of) managed to still be on my system and somehow make its way into the commit and it's asking me to sign with that account.

If necessary I will try and recover the account and sign the CLA, else I'm very sure that I've signed it as @delta1513 if only that is sufficient.

Let me know if there are other options that will make merging this PR easier.

As for the NEWS entry, I have it added. Please let me know if I got the format wrong or need to change anything.

I apologize for the inconvenience, I am much more accustomed to Gitlab :sweat_smile:

delta1513 avatar Feb 01 '23 21:02 delta1513

I just unlinked my old email from @delta1512 because I couldn't recover it.

Let me know if you want me to close and re-submit this PR as @delta1513 only.

delta1513 avatar Feb 01 '23 22:02 delta1513