cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-98240: Updated Path.rename docs, when it is atomic

Open mateka opened this issue 3 years ago • 2 comments
trafficstars

  • Issue: gh-98240

mateka avatar Oct 13 '22 18:10 mateka

All commit authors signed the Contributor License Agreement.
CLA signed

cpython-cla-bot[bot] avatar Oct 13 '22 18:10 cpython-cla-bot[bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-bot avatar Oct 14 '22 22:10 bedevere-bot

I don't like copying the docs of os.rename verbatim here. Should we just instead link to the docs of os.rename and say that's what Path.rename uses internally?

kwsp avatar Oct 18 '22 22:10 kwsp

I don't like copying the docs of os.rename verbatim here. Should we just instead link to the docs of os.rename and say that's what Path.rename uses internally?

I have changed PR to point to os.rename.

mateka avatar Oct 19 '22 08:10 mateka

I have made the requested changes; please review again

mateka avatar Oct 25 '22 08:10 mateka

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

bedevere-bot avatar Oct 25 '22 08:10 bedevere-bot

Thanks @mateka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. 🐍🍒⛏🤖

miss-islington avatar Jan 30 '23 01:01 miss-islington

Thanks @mateka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. 🐍🍒⛏🤖

miss-islington avatar Jan 30 '23 01:01 miss-islington

GH-101414 is a backport of this pull request to the 3.10 branch.

bedevere-bot avatar Jan 30 '23 01:01 bedevere-bot

GH-101415 is a backport of this pull request to the 3.11 branch.

bedevere-bot avatar Jan 30 '23 01:01 bedevere-bot