cpython
cpython copied to clipboard
gh-98240: Updated Path.rename docs, when it is atomic
- Issue: gh-98240
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
I don't like copying the docs of os.rename verbatim here. Should we just instead link to the docs of os.rename and say that's what Path.rename uses internally?
I don't like copying the docs of
os.renameverbatim here. Should we just instead link to the docs ofos.renameand say that's whatPath.renameuses internally?
I have changed PR to point to os.rename.
I have made the requested changes; please review again
Thanks for making the requested changes!
@brettcannon: please review the changes made to this pull request.
Thanks @mateka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. 🐍🍒⛏🤖
Thanks @mateka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. 🐍🍒⛏🤖
GH-101414 is a backport of this pull request to the 3.10 branch.
GH-101415 is a backport of this pull request to the 3.11 branch.