cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-93334: Fix homonym edge case in PathFinder.find_spec()

Open jacobtylerwalls opened this issue 3 years ago • 1 comments

  • Issue: gh-93334

jacobtylerwalls avatar Oct 08 '22 19:10 jacobtylerwalls

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-app[bot] avatar Jul 10 '24 23:07 bedevere-app[bot]

I have made the requested changes; please review again

(happy to continue adjusting the test setup to be more minimal, if there's a way)

jacobtylerwalls avatar Jul 26 '24 02:07 jacobtylerwalls

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

bedevere-app[bot] avatar Jul 26 '24 02:07 bedevere-app[bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-app[bot] avatar Sep 13 '24 22:09 bedevere-app[bot]

Thanks for the review! I have made the requested changes; please review again

jacobtylerwalls avatar Sep 15 '24 13:09 jacobtylerwalls

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

bedevere-app[bot] avatar Sep 15 '24 13:09 bedevere-app[bot]

@jacobtylerwalls sorry about the extreme delay in reviewing this! 😅 And thanks for the PR!

brettcannon avatar Sep 05 '25 22:09 brettcannon