cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-98284: better error message for undefined abstractmethod

Open kaushikcfd opened this issue 3 years ago • 16 comments
trafficstars

Error message before:

TypeError: Can't instantiate abstract class IndexNode with abstract method name

Error message after this patch:

TypeError: Can't instantiate abstract class IndexNode with abstract method 'name'

Given that the style-guide requires method names to be in lowercase, the quotation marks help in differentiating the sentence from the method's name.

  • Issue: gh-98284

kaushikcfd avatar Oct 06 '22 16:10 kaushikcfd

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

bedevere-bot avatar Oct 06 '22 16:10 bedevere-bot

All commit authors signed the Contributor License Agreement.
CLA signed

cpython-cla-bot[bot] avatar Oct 06 '22 16:10 cpython-cla-bot[bot]

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

bedevere-bot avatar Oct 06 '22 18:10 bedevere-bot

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

bedevere-bot avatar Oct 06 '22 18:10 bedevere-bot

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

bedevere-bot avatar Oct 07 '22 01:10 bedevere-bot

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

bedevere-bot avatar Oct 09 '22 14:10 bedevere-bot

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

bedevere-bot avatar Oct 09 '22 15:10 bedevere-bot

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

bedevere-bot avatar Oct 09 '22 15:10 bedevere-bot

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

bedevere-bot avatar Oct 09 '22 15:10 bedevere-bot

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

bedevere-bot avatar Oct 09 '22 15:10 bedevere-bot

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

bedevere-bot avatar Oct 09 '22 22:10 bedevere-bot

You do need a NEWS entry as the good knight Bedevere keeps telling you.

Also, avoid force-pushing; it makes review harder. We'll squash-merge anywhere when we merge a PR.

JelleZijlstra avatar Oct 09 '22 22:10 JelleZijlstra

You do need a NEWS entry as the good knight Bedevere keeps telling you.

Done!

Also, avoid force-pushing;

Noted, thanks!

kaushikcfd avatar Oct 09 '22 23:10 kaushikcfd

The CI failure is (most likely) unrelated:

PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'D:\\a\\cpython\\cpython\\build\\test_python_2628�\\test_python_worker_1152�'

kaushikcfd avatar Oct 15 '22 16:10 kaushikcfd

Retriggering CI, it is indeed unrelated.

sobolevn avatar Oct 15 '22 17:10 sobolevn

Retriggering CI, it is indeed unrelated.

Thanks, yep that was it.

kaushikcfd avatar Oct 15 '22 18:10 kaushikcfd

Soft ping.

kaushikcfd avatar Nov 04 '22 17:11 kaushikcfd