cpython
cpython copied to clipboard
gh-98284: better error message for undefined abstractmethod
Error message before:
TypeError: Can't instantiate abstract class IndexNode with abstract method name
Error message after this patch:
TypeError: Can't instantiate abstract class IndexNode with abstract method 'name'
Given that the style-guide requires method names to be in lowercase, the quotation marks help in differentiating the sentence from the method's name.
- Issue: gh-98284
Most changes to Python require a NEWS entry.
Please add it using the blurb_it web app or the blurb command-line tool.
Most changes to Python require a NEWS entry.
Please add it using the blurb_it web app or the blurb command-line tool.
Most changes to Python require a NEWS entry.
Please add it using the blurb_it web app or the blurb command-line tool.
Most changes to Python require a NEWS entry.
Please add it using the blurb_it web app or the blurb command-line tool.
Most changes to Python require a NEWS entry.
Please add it using the blurb_it web app or the blurb command-line tool.
Most changes to Python require a NEWS entry.
Please add it using the blurb_it web app or the blurb command-line tool.
Most changes to Python require a NEWS entry.
Please add it using the blurb_it web app or the blurb command-line tool.
Most changes to Python require a NEWS entry.
Please add it using the blurb_it web app or the blurb command-line tool.
Most changes to Python require a NEWS entry.
Please add it using the blurb_it web app or the blurb command-line tool.
Most changes to Python require a NEWS entry.
Please add it using the blurb_it web app or the blurb command-line tool.
You do need a NEWS entry as the good knight Bedevere keeps telling you.
Also, avoid force-pushing; it makes review harder. We'll squash-merge anywhere when we merge a PR.
You do need a NEWS entry as the good knight Bedevere keeps telling you.
Done!
Also, avoid force-pushing;
Noted, thanks!
The CI failure is (most likely) unrelated:
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'D:\\a\\cpython\\cpython\\build\\test_python_2628�\\test_python_worker_1152�'
Retriggering CI, it is indeed unrelated.
Retriggering CI, it is indeed unrelated.
Thanks, yep that was it.
Soft ping.