cpython gh-93121: change _sample_headers from a map to list + tuples to allow duplicates

gh-93121: change _sample_headers from a map to list + tuples to allow duplicates

Open AGZain opened this issue 3 years ago • 4 comments

trafficstars

Before:

https://github.com/python/cpython/blob/b2694ab46997746eae7e913738623b39f6334473/Lib/test/test_mailbox.py#L34-L35

https://github.com/python/cpython/blob/b2694ab46997746eae7e913738623b39f6334473/Lib/test/test_mailbox.py#L2267-L2290

Since _sample_headers is a map with duplicate keys (ex: Received), not all keys are tested.

After:

Changed _sample_headers to a list of tuples so all keys are tested

May 26 '22 03:05 AGZain

All commit authors signed the Contributor License Agreement.

May 26 '22 03:05 cpython-cla-bot[bot]

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

May 26 '22 03:05 bedevere-bot

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

May 28 '22 03:05 bedevere-bot

FWIW, "map" and "mapping" are two different things.

Jun 11 '22 13:06 rhettinger

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

Apr 06 '23 20:04 bedevere-bot