cpython
cpython copied to clipboard
gh-86819: Add constants for isotp.h which is included in Linux >= 5.10
This adds constants to the socket module which are provided by the new isotp module available in Linux >= 5.10.
https://bugs.python.org/issue42653 #86819
- Issue: gh-86819
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).
Recognized GitHub username
We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:
@rumpelsepp
This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.
You can check yourself to see if the CLA has been received.
Thanks again for the contribution, we look forward to reviewing it!
As the reporter or the original feature request this patch looks good to me.
(Although I hate autoconf magic)
(Although I hate autoconf magic)
As do I… Is there anything else I have to adjust here? My autoreconf version seems different and it mutilates the checked in configure script.
Please open a new issue: https://bugs.python.org/issue10141 is closed.
done
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
And if you don't make the requested changes, you will be poked with soft cushions!
I have made the requested changes; please review again
Thanks for making the requested changes!
@tiran: please review the changes made to this pull request.
This PR is stale because it has been open for 30 days with no activity.
Am I supposed to do any more changes here?
I have made the requested changes; please review again.
I rebased this against main and fixed the build. This one is now based on #26174.
Thanks for making the requested changes!
@tiran: please review the changes made to this pull request.
@rumpelsepp Thanks for working on this. I totally forgot about these pending PRs. @tiran Thanks in advance for reviewing. Please close my PR #26174 when this is merged.
I rebased this hoping it will eventually be merged. :)
I have made the requested changes; please review again
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
I have made the requested changes; please review again
Thanks for making the requested changes!
@erlend-aasland, @tiran: please review the changes made to this pull request.
@picnixz I addressed your review.
:robot: New build scheduled with the buildbot fleet by @erlend-aasland for commit ffae37c265c1bce95c78afd9e3e7ef1892b12b43 :robot:
If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.
Could you move the what's new entry to 3.15.rst instead?
Don't forget to re-add the NEWS entry (I don't know where it disppeared)
Your comments should be addressed now.
@picnixz Thank you for your review. I think I have catched up with your remarks.