cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-86819: Add constants for isotp.h which is included in Linux >= 5.10

Open rumpelsepp opened this issue 4 years ago • 14 comments

This adds constants to the socket module which are provided by the new isotp module available in Linux >= 5.10.

https://bugs.python.org/issue42653 #86819

  • Issue: gh-86819

rumpelsepp avatar Dec 16 '20 08:12 rumpelsepp

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@rumpelsepp

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

the-knights-who-say-ni avatar Dec 16 '20 08:12 the-knights-who-say-ni

As the reporter or the original feature request this patch looks good to me.

(Although I hate autoconf magic)

shawnl avatar Dec 16 '20 09:12 shawnl

(Although I hate autoconf magic)

As do I… Is there anything else I have to adjust here? My autoreconf version seems different and it mutilates the checked in configure script.

rumpelsepp avatar Dec 16 '20 09:12 rumpelsepp

Please open a new issue: https://bugs.python.org/issue10141 is closed.

vstinner avatar Dec 16 '20 09:12 vstinner

done

rumpelsepp avatar Dec 16 '20 09:12 rumpelsepp

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

bedevere-bot avatar Dec 16 '20 09:12 bedevere-bot

I have made the requested changes; please review again

rumpelsepp avatar Dec 16 '20 09:12 rumpelsepp

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

bedevere-bot avatar Dec 16 '20 09:12 bedevere-bot

This PR is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Jan 16 '21 01:01 github-actions[bot]

Am I supposed to do any more changes here?

rumpelsepp avatar May 05 '21 16:05 rumpelsepp

I have made the requested changes; please review again.

I rebased this against main and fixed the build. This one is now based on #26174.

rumpelsepp avatar Mar 01 '22 07:03 rumpelsepp

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

bedevere-bot avatar Mar 01 '22 07:03 bedevere-bot

@rumpelsepp Thanks for working on this. I totally forgot about these pending PRs. @tiran Thanks in advance for reviewing. Please close my PR #26174 when this is merged.

menschel avatar Mar 06 '22 10:03 menschel

I rebased this hoping it will eventually be merged. :)

I have made the requested changes; please review again

rumpelsepp avatar Jul 12 '24 08:07 rumpelsepp

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-app[bot] avatar Jul 16 '24 08:07 bedevere-app[bot]

I have made the requested changes; please review again

rumpelsepp avatar Jul 16 '24 08:07 rumpelsepp

Thanks for making the requested changes!

@erlend-aasland, @tiran: please review the changes made to this pull request.

bedevere-app[bot] avatar Jul 16 '24 08:07 bedevere-app[bot]

@picnixz I addressed your review.

rumpelsepp avatar Jul 30 '24 05:07 rumpelsepp

:robot: New build scheduled with the buildbot fleet by @erlend-aasland for commit ffae37c265c1bce95c78afd9e3e7ef1892b12b43 :robot:

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

bedevere-bot avatar Oct 14 '24 22:10 bedevere-bot

Could you move the what's new entry to 3.15.rst instead?

picnixz avatar Aug 22 '25 08:08 picnixz

Don't forget to re-add the NEWS entry (I don't know where it disppeared)

picnixz avatar Aug 22 '25 09:08 picnixz

Your comments should be addressed now.

rumpelsepp avatar Aug 22 '25 09:08 rumpelsepp

@picnixz Thank you for your review. I think I have catched up with your remarks.

rumpelsepp avatar Aug 22 '25 10:08 rumpelsepp