cpython icon indicating copy to clipboard operation
cpython copied to clipboard

GH-121584: Toggle helper instead of nesting instances when using key bindings

Open saucoide opened this issue 1 year ago • 4 comments

Adds a flag to check if the helper is active, interrupting it instead of opening a new instance if so

This is to stop F1 from opening multiple instances of help you need to quit individually before returning to the repl, maybe the toggling part with the sigint is not needed, but I figured paste_mode behaves that way so maybe this can too?

  • Issue: gh-121584

saucoide avatar Jul 13 '24 09:07 saucoide

All commit authors signed the Contributor License Agreement.
CLA signed

ghost avatar Jul 13 '24 09:07 ghost

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar Jul 13 '24 09:07 bedevere-app[bot]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar Jul 13 '24 09:07 bedevere-app[bot]

@ambv i just saw that the toggle behavior for help is mentioned explicitly in the pep, any chance this will get merged or is that part going to be reworked anyway and better not to introduce more stuff?

saucoide avatar Oct 24 '24 04:10 saucoide

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-app[bot] avatar Jan 21 '25 21:01 bedevere-app[bot]

All commit authors signed the Contributor License Agreement.

CLA signed

python-cla-bot[bot] avatar Apr 18 '25 09:04 python-cla-bot[bot]

bumping asking to take a look at this again, the latest version doesnt use signals anymore

I have made the requested changes; please review again

saucoide avatar Jul 19 '25 10:07 saucoide

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

bedevere-app[bot] avatar Jul 19 '25 10:07 bedevere-app[bot]