cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-118876: Set ns.temp before invoking its is_absolute method

Open i-shenl opened this issue 1 year ago • 4 comments
trafficstars

Fixes an AttributeError that occurs when checking if ns.temp is an absolute path during building from source on Windows.

  • Issue: gh-118876

i-shenl avatar May 10 '24 06:05 i-shenl

All commit authors signed the Contributor License Agreement.
CLA signed

cpython-cla-bot[bot] avatar May 10 '24 06:05 cpython-cla-bot[bot]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar May 10 '24 06:05 bedevere-app[bot]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar May 10 '24 15:05 bedevere-app[bot]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar May 10 '24 15:05 bedevere-app[bot]

Thanks @i-shenl for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. 🐍🍒⛏🤖

miss-islington-app[bot] avatar May 13 '24 11:05 miss-islington-app[bot]

Thanks @i-shenl for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. 🐍🍒⛏🤖

miss-islington-app[bot] avatar May 13 '24 11:05 miss-islington-app[bot]

GH-118994 is a backport of this pull request to the 3.12 branch.

bedevere-app[bot] avatar May 13 '24 11:05 bedevere-app[bot]

GH-118995 is a backport of this pull request to the 3.13 branch.

bedevere-app[bot] avatar May 13 '24 11:05 bedevere-app[bot]