core-workflow icon indicating copy to clipboard operation
core-workflow copied to clipboard

PR checks should require tests like they require docs

Open iritkatriel opened this issue 3 years ago • 8 comments

tests are as standard a requirement as doc changes. New PR authors who are not aware of this could be helped by a check failing due to lack of tests (rather than waiting for someone to comment on that, which can take years in some cases).

So the suggestion is:

Any PR that touches code must also touch the tests, or have a skip-tests label.

iritkatriel avatar Nov 27 '22 11:11 iritkatriel

It might be better to move this to python/bedevere, since he is the one performing checks related to the skip-* labels.

ezio-melotti avatar Nov 28 '22 02:11 ezio-melotti

AFAIK, there is no doc check/requirement, but I think there should be for enhancements. As I said on discord, I think we should at least try out both.

terryjreedy avatar Nov 28 '22 02:11 terryjreedy

It might be better to move this to python/bedevere, since he is the one performing checks related to the skip-* labels.

At the sprint we talked about replacing some Bedevere functionality with more "native" GitHub stuff.

For example, this could be done with GitHub Actions.

@brettcannon Do you think https://github.com/brettcannon/check-for-changed-files would be suitable for this?

hugovk avatar Nov 28 '22 12:11 hugovk

Do you think https://github.com/brettcannon/check-for-changed-files would be suitable for this?

Yes because that's what I designed it for. 😁 See https://github.com/microsoft/vscode-python/blob/133a8e877aa3755eaf101f1f1edf446432770b40/.github/workflows/pr-file-check.yml#L34-L43 as an example usage for this exact use case.

brettcannon avatar Nov 28 '22 23:11 brettcannon