blurb_it
blurb_it copied to clipboard
Test Python 3.14
Add 3.14, just like 3.13 was added in:
- #401
These are the same failures seen in:
- https://github.com/python/bedevere/pull/661
For the deprecation warning, we could add an exclusion to the pytest configuration, I believe?
A
Yes, the upstreams already know about it, let's update pytest.ini to something like this:
filterwarnings =
error
ignore:'asyncio.get_event_loop_policy' is deprecated and slated for removal in Python 3.16:DeprecationWarning:pytest_asyncio
ignore:'asyncio.iscoroutinefunction' is deprecated and slated for removal in Python 3.16; use inspect.iscoroutinefunction.. instead:DeprecationWarning:aiohttp
ignore:'asyncio.set_event_loop' is deprecated and slated for removal in Python 3.16:DeprecationWarning:pytest_asyncio
ignore:'asyncio.set_event_loop_policy' is deprecated and slated for removal in Python 3.16:DeprecationWarning:pytest_asyncio
Thanks for the ping, CLA Bot the Second.
Yes, the upstreams already know about it, let's update
pytest.inito something like this:filterwarnings = error ignore:'asyncio.get_event_loop_policy' is deprecated and slated for removal in Python 3.16:DeprecationWarning:pytest_asyncio ignore:'asyncio.iscoroutinefunction' is deprecated and slated for removal in Python 3.16; use inspect.iscoroutinefunction.. instead:DeprecationWarning:aiohttp ignore:'asyncio.set_event_loop' is deprecated and slated for removal in Python 3.16:DeprecationWarning:pytest_asyncio ignore:'asyncio.set_event_loop_policy' is deprecated and slated for removal in Python 3.16:DeprecationWarning:pytest_asyncio
Updated and CI is now green.
Hmm, the failure were the same as:
- https://github.com/python/bedevere/pull/661
but that was closed in favor of:
- https://github.com/python/bedevere/pull/662
which had no failures.
Around the same time, @dependabot also created a PR for this repo:
- https://github.com/python/blurb_it/pull/418
After merging it, I updated this branch hoping that the failures would disappear, as it happened for bedevere, but they didn't.
Upon further investigation, I noticed that some packages haven't been updated: https://github.com/python/blurb_it/blob/e10ab1baa0661d7cb80673f4fc8919b17e0b9b0d/requirements.txt#L1-L5
https://github.com/python/bedevere/pull/662 updated aiohttp to 3.11.15, which might have fixed the warnings, but that update wasn't included in #418.
The changelog for the releases (3.11.14/15) don't mention anything about the deprecation, but there is now a new release (3.11.16) that includes:
Replaced deprecated asyncio.iscoroutinefunction with its counterpart from inspect
We should be able to remove the filters and update aiohttp to 3.11.16 manually to fix the warnings and add 3.14.
I was also wondering why the updated wasn't included in #418. Turns out that on April 1st:
- #418 was created at 4:04AM
- https://github.com/aio-libs/aiohttp/releases/tag/v3.11.15 was released at 4:47AM
- https://github.com/python/bedevere/pull/662 was created at 9:01AM
This explains why 3.11.15 wasn't included in #418, but 3.11.14 was released 3 weeks ago and should have been included. Maybe @dependabot wanted to prank us creating PRs at 4:04AM with a dependency not found on April 1st?
The following issue is still not fixed and causes a few deprecation warnings:
- https://github.com/pytest-dev/pytest-asyncio/issues/1025
All the other issues seem to be fixed.
I think we can wait a bit more to see if this last issue gets fixed, and merge the PR once all the deprecation warnings are gone.
Note that there are also a couple of warnings that don't cause failures:
- https://github.com/pytest-dev/pytest-asyncio/issues/924
- https://github.com/pytest-dev/pluggy/issues/573
These are not blockers for this PR.
The following issue is still not fixed and causes a few deprecation warnings:
* [Use of `asyncio.get_event_loop_policy` deprecated in Python 3.14-dev pytest-dev/pytest-asyncio#1025](https://github.com/pytest-dev/pytest-asyncio/issues/1025)
The deprecation warnings have been addressed as part of pytest-asyncio v1.0.0 and should no longer bubble up to your test code.
Thanks all!
Thanks @seifertm for fixing the issue and releasing v1.0.0!
Tests are now passing on all branches, so this PR is ready to be merged. Every remaining warning can be addressed separately.