blurb_it
blurb_it copied to clipboard
Use underscores instead of spaces in paths
For https://github.com/python/core-workflow/issues/186.
Companion to https://github.com/python/core-workflow/pull/499.
I've not tested this other than running the unit tests.
I think this is all we need for blurb-it? For example, there's already "Tools-Demos" with no "/".
Sure, updated!
Updated to use underscores instead of hyphens, to match blurb, as decided during the EuroPython sprint: https://github.com/python/core-workflow/pull/499#issuecomment-1646975946
Is something still blocking this PR?
Yes, https://github.com/python/core-workflow/pull/499 needs merging first.
Is something blocking https://github.com/python/core-workflow/pull/499? :upside_down_face:
Someone to hit the big green merge button? I think it's ready.
I've released blurb 1.2.0 that now uses underscores for the directories:
https://github.com/python/blurb/releases/tag/v1.2.0
Let's give it a little bit of time for testing first, then we can mark this as ready for review/merge.
Let's give it a little bit of time for testing first, then we can mark this as ready for review/merge.
This is now ready for review/merge.
After it's merged and we've confirmed it's working, I'll post on Discuss to encourage people to upgrade their blurb CLI.
Further down the line, we can add a pre-commit check to prevent creation of dirs with spaces.
We already have an approval, let's merge! 🚀
Confirmed working: python/cpython@4ea1895 (#122242) :rocket: