blurb_it icon indicating copy to clipboard operation
blurb_it copied to clipboard

Use underscores instead of spaces in paths

Open hugovk opened this issue 2 years ago • 6 comments

For https://github.com/python/core-workflow/issues/186.

Companion to https://github.com/python/core-workflow/pull/499.

I've not tested this other than running the unit tests.

I think this is all we need for blurb-it? For example, there's already "Tools-Demos" with no "/".

hugovk avatar Mar 28 '23 20:03 hugovk

Sure, updated!

hugovk avatar Apr 03 '23 15:04 hugovk

Updated to use underscores instead of hyphens, to match blurb, as decided during the EuroPython sprint: https://github.com/python/core-workflow/pull/499#issuecomment-1646975946

hugovk avatar Jul 26 '23 15:07 hugovk

Is something still blocking this PR?

ezio-melotti avatar Oct 12 '23 07:10 ezio-melotti

Yes, https://github.com/python/core-workflow/pull/499 needs merging first.

hugovk avatar Oct 12 '23 07:10 hugovk

Is something blocking https://github.com/python/core-workflow/pull/499? :upside_down_face:

ezio-melotti avatar Oct 12 '23 07:10 ezio-melotti

Someone to hit the big green merge button? I think it's ready.

hugovk avatar Oct 12 '23 07:10 hugovk

I've released blurb 1.2.0 that now uses underscores for the directories:

https://github.com/python/blurb/releases/tag/v1.2.0

Let's give it a little bit of time for testing first, then we can mark this as ready for review/merge.

hugovk avatar Jul 07 '24 18:07 hugovk

Let's give it a little bit of time for testing first, then we can mark this as ready for review/merge.

This is now ready for review/merge.

After it's merged and we've confirmed it's working, I'll post on Discuss to encourage people to upgrade their blurb CLI.

Further down the line, we can add a pre-commit check to prevent creation of dirs with spaces.

hugovk avatar Jul 19 '24 09:07 hugovk

We already have an approval, let's merge! 🚀

hugovk avatar Jul 25 '24 15:07 hugovk

Confirmed working: python/cpython@4ea1895 (#122242) :rocket:

hugovk avatar Jul 25 '24 16:07 hugovk