triopg icon indicating copy to clipboard operation
triopg copied to clipboard

Dependency on `asynccontextgenerator`

Open thearchitector opened this issue 2 years ago • 4 comments

@asynccontextgenerator is available in the standard contextlib module from Python 3.7+, and available via package for 3.5 and 3.6.

This uses the package, but its not listed as a dependency. It would nice for it to be listed as one for specifically 3.5/6, via the python_version meta, with a corresponding check in the actual code to just use the std lib one if its available instead.

thearchitector avatar Aug 10 '23 22:08 thearchitector

https://github.com/python-trio/triopg/blob/ccf44f9b40f0dc1945b8dcd152deaba11f195b28/triopg/_triopg.py#L6

I'd prefer to replace this with the contextlib version, and explicitly drop support for end-of-life versions of Python via python_requires=">=3.8". @jakkdl?

Zac-HD avatar Oct 26 '23 13:10 Zac-HD

on it!

jakkdl avatar Oct 26 '23 13:10 jakkdl

oh boi, the test infra is horribly outdated.

jakkdl avatar Oct 26 '23 13:10 jakkdl

on it!

dropping this. Writing the PR is fairly trivial, so if anybody does use triopg and want to update it and/or do other maintaining I'd recommend they do it. I'm instead creating #21

jakkdl avatar Feb 01 '24 13:02 jakkdl