trio-websocket
trio-websocket copied to clipboard
python-trio
Blacken
I'm working on fixing a bug with connection shutdown, and standarizing the formatting first makes the source easier to work with
to be clear: this is literally just black trio_websocket tests, no configuration, no other edits.
OK the last two commits did actually change things in trivial ways to get the lint passing. Still no semantic changes, or even syntactic ones.
Thank you for investigating that problem.
I'm not a fan of blacken formatting*, but the plea I'll make is that making a huge formatting change is not ideal for a project on life support. With a legacy codebase and departed authors, it's critical to be able to dig through code history and understand things-- I'd rather avoid having to navigate through this diff on every blame output going forward.
Would it be reasonable to revisit if the project becomes more actively maintained?
[*] - for example, some of the formatting choices are not friendly to vertical footprint, and I do 100% development on a small laptop having a short ratio display.
I was requested to add type hints to this repository, so
Would it be reasonable to revisit if the project becomes more actively maintained?
is now relevant. I would vastly prefer if the code was black-formatted for me to change stuff.
With a legacy codebase and departed authors, it's critical to be able to dig through code history and understand things-- I'd rather avoid having to navigate through this diff on every blame output going forward.
you can tell git blame to ignore certain commits by adding their ID in a file named .git-blame-ignore-revs. We can't do it in this PR (or at least I failed when I tried earlier) due to squashing and merging changing IDs, but can do it in a followup PR.
Current test failures are from old code trying to use MultiError, which no longer exists.
Turns out I just missed adding some pylint ignores, as it knows that trio doesn't have MultiError anymore but the code in question was meant for handling said older versions of Trio.