install.python-poetry.org icon indicating copy to clipboard operation
install.python-poetry.org copied to clipboard

Print correct final MSStore Python bin dirs after install

Open hintron opened this issue 3 years ago • 7 comments
trafficstars

The installer class still had the unresolved, old bin dirs before being resolved. So they were incorrectly being printed at the end of the install.

hintron avatar Nov 17 '22 07:11 hintron

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
install-python-poetry-org ✅ Ready (Inspect) Visit Preview Nov 17, 2022 at 7:39AM (UTC)

vercel[bot] avatar Nov 17 '22 07:11 vercel[bot]

This is a follow up to #18 and https://github.com/python-poetry/poetry/pull/5931.

I am on Windows with Git Bash, using the Microsoft Store Python. The installer script correctly installs Poetry into the sandboxed location provided by the MSStore Python. However, the final message printed to the user by the install script is wrong. It uses the old, unresolved bin path, which points to nothing.

My fix is to pass back the env object's bin dir to the installer object, and if it is different than the installer object's bin dir, then assume it was resolved to something else and print that.

I just hacked something together as a starting point. It does the job, but should be iterated on.

hintron avatar Nov 17 '22 07:11 hintron

This is not mergable -- we don't want to hardcode Windows assumptions like this (and indeed, the "fix" from #18 actually should be partially reverted as it breaks some scenarios). I've got a branch locally which solves some of these issues, I'll try to dust it off in the next few days.

neersighted avatar Nov 17 '22 15:11 neersighted

@neersighted sorry to bother you, but is there a chance we can get your local branch upstream soon?

Trolldemorted avatar Jun 23 '23 21:06 Trolldemorted

This issue still remains in August 2023. No progress here? This wrong message in the console really makes a whole lot of confusion.

temeddix avatar Aug 08 '23 02:08 temeddix

Just ran into this as well.

The current situation is considerably confusing, as the installation instructions at https://python-poetry.org/docs/ explicitly mention Python from the Windows Store, implicitly suggesting to the user that it is supported. Yet, after following the on-screen instructions, poetry is not available. Until this is fixed, it would probably be better to explicitly document Windows Store installs as unsupported.

dnadlinger avatar Sep 16 '23 21:09 dnadlinger

Agreed, at least we should mention that MS Store Python is not supported

temeddix avatar Sep 16 '23 21:09 temeddix