bot icon indicating copy to clipboard operation
bot copied to clipboard

Subtract replies in mentions rule

Open mbaruh opened this issue 3 years ago • 3 comments

The purpose of the mentions rule is to catch people spamming user mentions, but message.mentions shows the user being replied to, if the reply is pinging, which is out of scope for what the rule is trying to catch.

The replies should be subtracted when counting the number of mentions, and messages with only a reply but no mentions should not be returned.

mbaruh avatar Dec 16 '21 20:12 mbaruh

if no one else wants to do this tonight, I can see about taking a look in a few hours.

onerandomusername avatar Dec 16 '21 21:12 onerandomusername

I'd like to add to this.. while there, also don't count the author's own mention, if for some reason they mention themselves.

onerandomusername avatar Dec 17 '21 05:12 onerandomusername

I can implement this if someone assigns me.

onerandomusername avatar Dec 17 '21 05:12 onerandomusername