attrs icon indicating copy to clipboard operation
attrs copied to clipboard

Fixes issue #1427

Open redruin1 opened this issue 7 months ago • 2 comments

Summary

Values given to __init__ should now always be propagated to __attrs_pre_init__, regardless of default configuration. Resolves #1427.

Pull Request Check List

  • [x] Do not open pull requests from your main branch – use a separate branch!
  • [x] Added tests for changed code.
  • [x] New features have been added to our Hypothesis testing strategy.
  • [x] Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
    • [x] ...and used in the stub test file tests/typing_example.py.
    • [x] If they've been added to attr/__init__.pyi, they've also been re-imported in attrs/__init__.pyi.
  • [x] Updated documentation for changed code.
    • [x] New functions/classes have to be added to docs/api.rst by hand.
    • [x] Changes to the signatures of @attr.s() and @attrs.define() have to be added by hand too.
    • [x] Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives. The next version is the second number in the current release + 1. The first number represents the current year. So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0. If the next version is the first in the new year, it'll be 23.1.0.
      • [x] If something changed that affects both attrs.define() and attr.s(), you have to add version directives to both.
  • [x] Documentation in .rst and .md files is written using semantic newlines.
  • [x] Changes (and possible deprecations) have news fragments in changelog.d.
  • [x] Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

redruin1 avatar Apr 18 '25 21:04 redruin1

@hynek Is there anything more I need to do on this PR, or is this not considered a bug?

redruin1 avatar Jun 10 '25 20:06 redruin1

hey @redruin1 sorry for letting you hang; I've currently too many fires everywhere and am procrastinating to attack the whole pile within attrs. I swear I feel bad and will get around to it!

hynek avatar Jun 12 '25 05:06 hynek