attrs
attrs copied to clipboard
Fixes issue #1427
Summary
Values given to __init__ should now always be propagated to __attrs_pre_init__, regardless of default configuration. Resolves #1427.
Pull Request Check List
- [x] Do not open pull requests from your
mainbranch – use a separate branch! - [x] Added tests for changed code.
- [x] New features have been added to our Hypothesis testing strategy.
- [x] Changes or additions to public APIs are reflected in our type stubs (files ending in
.pyi).- [x] ...and used in the stub test file
tests/typing_example.py. - [x] If they've been added to
attr/__init__.pyi, they've also been re-imported inattrs/__init__.pyi.
- [x] ...and used in the stub test file
- [x] Updated documentation for changed code.
- [x] New functions/classes have to be added to
docs/api.rstby hand. - [x] Changes to the signatures of
@attr.s()and@attrs.define()have to be added by hand too. - [x] Changed/added classes/methods/functions have appropriate
versionadded,versionchanged, ordeprecateddirectives. The next version is the second number in the current release + 1. The first number represents the current year. So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0. If the next version is the first in the new year, it'll be 23.1.0.- [x] If something changed that affects both
attrs.define()andattr.s(), you have to add version directives to both.
- [x] If something changed that affects both
- [x] New functions/classes have to be added to
- [x] Documentation in
.rstand.mdfiles is written using semantic newlines. - [x] Changes (and possible deprecations) have news fragments in
changelog.d. - [x] Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.
@hynek Is there anything more I need to do on this PR, or is this not considered a bug?
hey @redruin1 sorry for letting you hang; I've currently too many fires everywhere and am procrastinating to attack the whole pile within attrs. I swear I feel bad and will get around to it!