pytest-splinter icon indicating copy to clipboard operation
pytest-splinter copied to clipboard

Screenshots won't work with pytest 5

Open pedrospdc opened this issue 6 years ago • 1 comments

In _browser_screenshot_session, you have the following code:


    fixture_values = (
        # pytest 3
        getattr(request, '_fixture_values', {}) or
        # pytest 2
        getattr(request, '_funcargs', {})
    )

    for name, value in fixture_values.items():

None of these getters are set in pytest 5.

pedrospdc avatar Oct 21 '19 12:10 pedrospdc

Is the problem still applicable? We're on pytest 7 and the code seems to be working just fine. Please let me know if this is still a problem, or even better, submit a PR with fix. Thanks.

mpasternak avatar Aug 07 '22 08:08 mpasternak