pytest-rerunfailures icon indicating copy to clipboard operation
pytest-rerunfailures copied to clipboard

Support isolated builds for toxfile

Open gnikonorov opened this issue 5 years ago • 4 comments

Tox supports isolated builds and we should take advantage of this.

Supporting this feature would require the creation of a pyproject.toml to inform tox how to perform the build. The one in pytest may be a good starting point.

Raised from description in https://github.com/pytest-dev/pytest-rerunfailures/pull/117

gnikonorov avatar Jul 30 '20 22:07 gnikonorov

As I cannot quickly get all the pros and cons about the isolated builds in my head, could you please provide some more information on this?

sallner avatar Jul 31 '20 12:07 sallner

@sallner isolated builds should speed up the tests a bit as it will only build the dist once - also it makes the tests more realistic as you are testing on an artefact even close to the end product shipped to pypi

graingert avatar Jul 31 '20 12:07 graingert

I am not yet convinced about adding another configuration file, but let's give it a try. Are there any caveats concerning coverage?

sallner avatar Aug 03 '20 15:08 sallner

pytest and tox will both read from pyproject.toml

graingert avatar Aug 03 '20 18:08 graingert