pytest-factoryboy icon indicating copy to clipboard operation
pytest-factoryboy copied to clipboard

Allow disabling Subfactory fixture replacing - might create circular dependencies

Open charlax opened this issue 7 years ago • 2 comments

Because pytest-factoryboy replaces SubFactory with registered factories, it is possible to inadvertently create circular dependencies, which are not detected by pytest.

In my case, the setup was the following:

  1. User factory
  2. Company factory with a Contact subfactory.
  3. user fixture overridden in the test file, depending on the company fixture
  4. contact fixture overridden in the same file, depending on the company fixture.

Normally it should be fine because user -> company and contact -> company - there's no cycle. But, because the plugin creates a dependency company -> contact, the graph becomes: user -> company -> contact -> company and there's a cycle. Yet this cycle is a bit magical - I did not ask for company.contact and contact.company to be the same... I want a new, unrelated contact to be created for each company.

Would it be possible to add an option to disable this for those who don't need it? Or only some whitelisted subfactories? In my case, I would like the company.contact factory to be unrelated to the contact factory.

charlax avatar Oct 19 '18 17:10 charlax

Any update here? This is a big issue for me...

charlax avatar May 17 '19 08:05 charlax

Apologies for missing this. Is it still an issue?

youtux avatar Jul 23 '23 20:07 youtux