rust-embed icon indicating copy to clipboard operation
rust-embed copied to clipboard

Published 20 hours ago • verified publisher icon pyrossh

Rename RustEmbed trait to Embed?

Open timClicks opened this issue 2 years ago • 5 comments
trafficstars

Would it be possible to shorten the name of the main trait exported by this library?

I don't see any particular reason to include the word "Rust" in the trait name, apart from it originating from a crate with the same name.

timClicks avatar Oct 28 '23 07:10 timClicks

Nice Idea. But this has gotta be a collective decision? Can we get some upvotes.

pyrossh avatar Nov 03 '23 08:11 pyrossh

Would be a breaking change and require major version bump, but I agree this makes sense to change.

BBaoVanC avatar Nov 05 '23 00:11 BBaoVanC

Anyone want to submit a PR for this?

pyrossh avatar Dec 02 '23 07:12 pyrossh

A non-breaking (I think?) change would be to reexport RustEmbed as Embed, preserving RustEmbed in place (like so: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=0037fc65e543296c1dc21af0235463c7)

osiewicz avatar Dec 02 '23 23:12 osiewicz

Nice idea. We could update the docs and Readme as well for this so would be the new de-facto way.

pyrossh avatar Dec 03 '23 11:12 pyrossh