pyroscope-java icon indicating copy to clipboard operation
pyroscope-java copied to clipboard

Support for JFR Event Streaming

Open REASY opened this issue 1 year ago • 1 comments

JEP 349: JFR Event Streaming has been around for some time. Should be there a support for JFR event streaming?

Consideration regarding performance, the article A Closer Look at JFR Streaming used OpenJDK 15 and found the performance isn't great.

REASY avatar Nov 28 '24 08:11 REASY

There is initial support for JFR in my PR, JFR streaming looks also like interesting option, my PR uses jdk.jfr.recording or jcmd (it depends which strategy you choose), https://github.com/grafana/pyroscope-java/pull/136

kcrimson avatar Feb 04 '25 11:02 kcrimson

Consideration regarding performance, the article A Closer Look at JFR Streaming used OpenJDK 15 and found the performance isn't great.

@REASY that article contains no representative benchmarks of JFR streaming. The allocations are dominated by producing 1.5 GB of Strings and writing them to a file via a BufferedWriter, see here.

I wouldn't say the author "found the performance isn't great," given that they open the benchmark section with

Benchmarks of Using JFR Streaming Wrongly

For laughs and giggles, …

viluon avatar Apr 19 '25 11:04 viluon