pyroscope-java icon indicating copy to clipboard operation
pyroscope-java copied to clipboard

Support pprof format natively

Open tomershafir opened this issue 2 years ago • 1 comments

The pyroscope ecosystem is around Go pprof. I think it makes sense that the agent would be able to emit pprof natively in order to improve data flows that would operate on the canonical form. It can make them simpler and more efficient. For example:

  • it will make writing tools in different languages easier with the oss pprof support, as I only see async-profiler java jfr2pprof (which you use in JPProf) and your Go server parser for JFR. I have a node app (unfortunately) where I need to simulate some pyroscope api and I would like to receive pprof
  • apply a more efficient format early
  • provide flexibility to tradeoff parse performance overhead across the pipeline depending on the use case, for example offload large scale parse work to the distributed data plane where it may be more negligible.

I think this should be complementary to an agent capability https://github.com/grafana/alloy/issues/395

tomershafir avatar Oct 16 '23 13:10 tomershafir

Yes please I think the best we could do is actually send using the new API so all in for doing a pprof conversion.

This will make also Grafana Agent integrations much easier for java.

cyriltovena avatar Oct 23 '23 12:10 cyriltovena