Dan Lynch
Dan Lynch
https://github.com/cosmos/cosmjs/pull/1290/files
I think I see the issue here. We include the cosmos protos but not the aminos... https://github.com/osmosis-labs/osmojs/blob/a6fdbc2ce3579cf2e90822c96edde2749eb78645/packages/osmojs/src/codegen/osmosis/client.ts#L38-L39 In this case to get things working today, I would suggest not using...
this may be required for infinitely recursive structures. Part of why this PR didn't get merged, it seemed that some structures were infinitely nested: https://github.com/osmosis-labs/telescope/pull/198
## types themselves - [x] `CoinSDKType` - [x] `CoinAminoType` is like SDKType but with these https://github.com/osmosis-labs/telescope/blob/main/PROTO-AMINO.md ## encoders - [ ] string - [x] numbers - [x] long - [...
## enum example ```js "/cosmos.gov.v1beta1.MsgVote": { aminoType: "cosmos-sdk/MsgVote", toAmino: ({ option, proposalId, voter }: MsgVote): AminoMsgVote["value"] => { return { option: option, proposal_id: proposalId.toString(), voter: voter, }; }, fromAmino: ({...
related https://github.com/CosmWasm/ts-codegen/issues/77
I'm wondering if we should try to autogenerate some of the documentation leveraging the types. Probably better than manually writing them :)
thanks @liangping ! will be integrating this into our gRPC client class. Appreciate the help!
@sascha1337 @liangping does this look like a good reference implementation? https://github.com/cosmos/cosmjs/blob/main/packages/stargate/src/modules/bank/queries.ts#L20-L59 It looks like they were actually using this? https://github.com/confio/cosmjs-types/blob/main/src/cosmos/bank/v1beta1/query.ts#L1079 I think we can improve it a bit? Some ideas:...
thank you @liangping 🙌🏻 this is great to have all the information we need for this issue in one place. > I confirm that tmclient is implemented based on http,...