setuptools icon indicating copy to clipboard operation
setuptools copied to clipboard

Removing error prone undefined late binding for Darwin builds

Open rickmark opened this issue 2 years ago • 2 comments

This flag causes the linker to succeed and insert dlsym for undefined values which will cause numerious run time issues that are compile time issues with ext modules

Summary of changes

Do not request darwin (macOS) linker to ignore undefined symbols

Closes

Pull Request Checklist

rickmark avatar Mar 09 '23 02:03 rickmark

Additionally I think setuptools may have to be modernized for clang on Apple platforms, including using -bundle instead of dynamiclib.

The additional linker stripping statement might also only be for when compiling as debug

rickmark avatar Mar 13 '23 19:03 rickmark

Can you give an example of how the existing behavior has caused issues? It may be worthwhile to create a test that captures the expected behavior, so that someone wishing to re-introduce this flag would have a reason not to. I acknowledge that the code isn't particularly robust, so I'd like to use this opportunity to help make it more robust.

jaraco avatar Jun 21 '23 14:06 jaraco