setuptools
setuptools copied to clipboard
Removing error prone undefined late binding for Darwin builds
This flag causes the linker to succeed and insert dlsym for undefined values which will cause numerious run time issues that are compile time issues with ext modules
Summary of changes
Do not request darwin (macOS) linker to ignore undefined symbols
Closes
Pull Request Checklist
- [NA] Changes have tests - Existing tests pass
- [NA] News fragment added in
changelog.d/. (See documentation for details)
Additionally I think setuptools may have to be modernized for clang on Apple platforms, including using -bundle instead of dynamiclib.
The additional linker stripping statement might also only be for when compiling as debug
Can you give an example of how the existing behavior has caused issues? It may be worthwhile to create a test that captures the expected behavior, so that someone wishing to re-introduce this flag would have a reason not to. I acknowledge that the code isn't particularly robust, so I'd like to use this opportunity to help make it more robust.