setuptools icon indicating copy to clipboard operation
setuptools copied to clipboard

Trigger deprecation warning when find_packages() finds reserved name

Open mgorny opened this issue 3 years ago • 5 comments

Summary of changes

Trigger SetuptoolsDeprecationWarning whenever find_packages() finds a top-level package whose name is found in reserved package name list, e.g. "tests". Installing these packages is probably always wrong, yet it is still a frequent mistake in packages using setuptools. This warning should increase the chance of the mistake being caught before releasing.

Closes #3243

Pull Request Checklist

mgorny avatar Apr 11 '22 10:04 mgorny

I have to admit that I went with the "minimal change" approach. If you prefer it done some other way, please let me know.

mgorny avatar Apr 11 '22 10:04 mgorny

I'm sorry but due to health issues I'll have to limit my computer activity for some time (apparently up to 4 weeks), so I won't be able to look into it any time soon.

mgorny avatar Apr 16 '22 16:04 mgorny

Sorry to hear that... I wish you a good recovery.

abravalheri avatar Apr 16 '22 16:04 abravalheri

Thank you very much.

mgorny avatar Apr 16 '22 18:04 mgorny

@mgorny I hope you're back to health. I thought I'd check in on this PR and see if you wanted to continue with it?

jaraco avatar Jun 21 '23 21:06 jaraco