emit warning when using VCS dependency without editable flag

[belm0]

As a user, it took me a long time to figure out why transitive dependencies of a VCS dependency weren't appearing in my lockfile. The symptom is subtle, and the correction is obscure (i.e. not intuitive why a VCS dependency needs to be declared editable, and it took me 20 minutes of searching old issues to find the hint).

pipenv seems to be aware of the specific dependencies of the the VCS dependency, and that they won't be added to the lockfile when the VCS dependency is not editable. Could it offer a warning to the user?

[duplicate-issues[bot]]

Hey @belm0,

We did a quick check and this issue looks very darn similar to

• #3269 - Latest pythonfinder logic cant handle pyenv and --two combination
• #3268 - Ignore hashes when using `--skip-lock`
• #3267 - setting 'index' option for package doesn't guarantee package will be installed from index

This could be a coincidence, but if any of these issues solves your problem then I did a good job :smile:

If not, the maintainers will get to this issue shortly.

Cheers, Your Friendly Neighborhood ProBot

[techalchemy]

I thought we did this already... :|

[belm0]

Perhaps I missed the warning, but I'd expect it during the lock operation:

[packages]
trio-websocket = { git = "https://github.com/HyperionGray/trio-websocket" }

$ pipenv --version
pipenv, version 2018.11.14

$ pipenv lock
Locking [dev-packages] dependencies…
Locking [packages] dependencies…
✔ Success!
Updated Pipfile.lock (465138)!

[techalchemy]

well darn, we used to warn people about this! I agree with you