flit icon indicating copy to clipboard operation
flit copied to clipboard

Published 20 hours ago • verified publisher icon pypa

Update development.rst

Open jdrumgoole opened this issue 3 years ago • 1 comments

Missing a package from the list of packages. Specifically tomli.

jdrumgoole avatar Dec 01 '21 23:12 jdrumgoole

I think it's OK to leave tomli-w out of this list - it should get installed anyway as a dependency of Flit. But let's take toml out of the list, because tomli replaced that. :slightly_smiling_face:

takluyver avatar Dec 02 '21 09:12 takluyver

Did #573 change anything here? On modern systems, tomli shouldn't be needed anymore, yet tomli-w will be.

joukewitteveen avatar Oct 03 '22 08:10 joukewitteveen

I don't think any TOML libraries should need to be manually installed any more. tomli is bundled in flit_core, and tomli_w is only used for a couple of pieces like flit init, so Flit should be able to install itself without that. tomli_w and any other missing dependencies will still get installed - we only need to pre-install enough to handle installation.

takluyver avatar Oct 03 '22 10:10 takluyver

I guess that means this PR can be closed and replaced by one that removes toml from line 8 of development.rst (the same line that this PR tried to add tomli to).

joukewitteveen avatar Oct 03 '22 12:10 joukewitteveen

Yup, that sounds right. Feel free to make that PR. :slightly_smiling_face:

takluyver avatar Oct 03 '22 17:10 takluyver