flit icon indicating copy to clipboard operation
flit copied to clipboard

Fix warnings when building the documentation.

Open Mariatta opened this issue 7 years ago • 11 comments

Fix the warning related to --repository option. Add sphinx to requirements-test. Run make html as part of travis CI.

Closes https://github.com/takluyver/flit/issues/189

Mariatta avatar Aug 28 '18 02:08 Mariatta

Hmm, why wouldn't python3 -m flit install --deps develop install sphinx, a doc extras?

Mariatta avatar Aug 30 '18 02:08 Mariatta

Hmm, why wouldn't python3 -m flit install --deps develop install sphinx, a doc extras?

From the logs it logs like it pulls pyproject.toml from the pip-installed flit. Try to bump version in __init__ to 1.1.dev ?

Carreau avatar Aug 30 '18 18:08 Carreau

Ah, I see. Do you think 1.1.post0 would make more sense? Or 1.2.dev0? I think it should also be its own change, separate from this PR.

Mariatta avatar Aug 30 '18 19:08 Mariatta

Hum, 1.2.dev ? I guess you can try here see if it fixes stuff and then we can advise. Still strange it uses the pip-installed one... We should try to figure out why.

Also it's just my guess, I may be wrong !

On Thu, Aug 30, 2018, 12:07 Mariatta [email protected] wrote:

Ah, I see. Do you think 1.1.post0 would make more sense? Or 1.2.dev0? I think it should also be its own change, separate from this PR.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/takluyver/flit/pull/201#issuecomment-417432951, or mute the thread https://github.com/notifications/unsubscribe-auth/AAUez9UzFl9BQBDhKMAy5IXaQgL4T3nLks5uWDf2gaJpZM4WO0Lk .

Carreau avatar Aug 30 '18 19:08 Carreau

Thanks, tested on my machine, and bumping the release number fixed it.

Mariatta avatar Aug 30 '18 19:08 Mariatta

This is now passing on Travis Python v3.6 and 3.7. I don't know what the problem is with Python 3.5, 3.4. Will look into it later.

Mariatta avatar Aug 30 '18 20:08 Mariatta

It's and installation issue. zipfile36 does not get installed on 3.4 and 3.5. They are not installed anymore. I can try to fix that for you.

Carreau avatar Aug 30 '18 20:08 Carreau

All green on travis ! 🥇to @Mariatta !

Appveyor seem to have hit a random error.

Carreau avatar Aug 30 '18 20:08 Carreau

Appveyor seem to have hit a random error.

(and I'm not allowed to restart...)

Carreau avatar Aug 30 '18 20:08 Carreau

Thanks @Carreau. Yeah we've seen that strange error on appveyor before ☹️

I was wondering we can move all dependencies from requirements-test into "test" extras in pyproject.toml, and not rely on requirements-test anymore. But I think that's out of the scope of this PR :)

Mariatta avatar Aug 30 '18 20:08 Mariatta

I'm trying push flit forwards a bit. I've got the docs building without warnings now, with a slightly different approach.

If you're still interested in this (or anyone else reading this), I'd still be interested in having a convenient way to check that the docs build without warnings. Now it would make sense to integrate that into the tox config.

takluyver avatar Nov 23 '19 18:11 takluyver