matplotlib-pyodide icon indicating copy to clipboard operation
matplotlib-pyodide copied to clipboard

Replace maxdict with lru_cache

Open hoodmane opened this issue 1 year ago • 1 comments

Matplotlib removed maxdict: https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.6.0.html#miscellaneous-internals

I asked about this on the matplotlib discourse: https://discourse.matplotlib.org/t/matplotlib-pyodide-font-caching-with-maxdict-and-lru-cache/24260

hoodmane avatar Feb 10 '24 19:02 hoodmane

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@61935f7). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             main     #52   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?       4           
  Lines           ?     648           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?     648           
  Partials        ?       0           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 10 '24 19:02 codecov-commenter

What's the status of this PR?

juntyr avatar Oct 22 '24 06:10 juntyr

I don't really understand matplotlib, so it's difficult to judge whether the patch is correct or not and I don't have that much faith in our test coverage. But it seems okay so we could just merge it and see if it unblocks the update. It would be nice to upstream some of the stuff but we have nobody who either understands matplotlib or wants to spend time learning about it. So it might be best just to wait until someone shows up with the inclination to maintain this.

hoodmane avatar Oct 22 '24 12:10 hoodmane

I think we can merge and release? @hoodmane

ryanking13 avatar Oct 22 '24 12:10 ryanking13