tangos icon indicating copy to clipboard operation
tangos copied to clipboard

`pip install`ed version do not seem to include the .svg files

Open cphyc opened this issue 2 years ago • 3 comments

When doing a pip install of tangos, it seems the web GUI cannot properly find the SVG files required to display the filtering (see image attached below)

This is what I get when installing tangos from source with pip install -e . image

When doing pip install . or pip install tangos, the ^ and v and filter svg symbols do not display. When inspecting the HTML, these SVGs are actually pointing to URLs with a 404 error.

cphyc avatar Sep 19 '23 09:09 cphyc

Oh dear! Any ideas why?

apontzen avatar Sep 19 '23 09:09 apontzen

The issue is that the SVG files aren't included in the MANIFEST. The following patch seems to do the trick

diff --git a/MANIFEST.in b/MANIFEST.in
index 06996e6..81b38df 100644
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -1 +1 @@
-recursive-include tangos *.png *.css *.gif *.js *.jinja2 *.ini
+recursive-include tangos *.png *.css *.gif *.js *.jinja2 *.ini *.svg

cphyc avatar Sep 19 '23 10:09 cphyc

Thanks, #227 implements this and also deals with a failing unit test on recent versions of numpy (I hope, awaiting the CI results)

apontzen avatar Sep 19 '23 20:09 apontzen