research icon indicating copy to clipboard operation
research copied to clipboard

Article informative priors

Open cetagostini-wise opened this issue 1 year ago • 5 comments

Changes log:

  • [x] Correction of strings style by @juanitorduz

  • [x] Correction of causalpy plot dates style by @juanitorduz

  • [x] Correction of derivative plot legends by @juanitorduz

  • [x] Recommendation about utilise pm.find_constrained_prior by @juanitorduz

  • [x] Recommendation about reference article by @juanitorduz

  • [x] Applying Isort & Ruff by @juanitorduz and @wd60622

  • [x] Correction in the narrative to create a more engaging content and skip the DGP by @ulfaslak & @drbenvincent

  • [x] Deeper explanation about how we are using CausalPy to estimate the total effect @drbenvincent

  • [x] Deeper explanation about how to find the prior values by @wd60622

cetagostini-wise avatar Apr 20 '24 13:04 cetagostini-wise

@twiecki would it be possible to allow the ReviewNB for this repository so that we can provide feedback on the notebook directly 🙏 ?

juanitorduz avatar Apr 20 '24 14:04 juanitorduz

If adding ReviewNB is not possible a workaround is to use jupytext to automatically generate .md files. Not at nice as ReviewNB, but reading and commenting .md files is better than just notebooks.

aloctavodia avatar Apr 20 '24 14:04 aloctavodia

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

added

twiecki avatar Apr 21 '24 16:04 twiecki

@juanitorduz You ask to add uncertainty in the prior plots but, I didn't add it in the plots because the intervals are to wide and makes the images look very strange, and pick a lower interval could be seeing as guiding the information in a "convenient" way at best.

cetagostini-wise avatar Apr 21 '24 22:04 cetagostini-wise