pymc-marketing icon indicating copy to clipboard operation
pymc-marketing copied to clipboard

Published 20 hours ago • verified publisher icon pymc-labs

Example NB plots are compressed

Open twiecki opened this issue 1 year ago • 8 comments

image

https://www.pymc-marketing.io/en/stable/notebooks/mmm/mmm_lift_test.html

twiecki avatar May 02 '24 19:05 twiecki

noticed that too ☹️

williambdean avatar May 02 '24 19:05 williambdean

This is also impacting the CLV notebooks. I tried changing the fig size in the plotting code, but it made no difference. I'm thinking we need to specify something in conf.py related to pydata-sphinx-theme.

ColtAllen avatar May 02 '24 20:05 ColtAllen

Maybe @OriolAbril has an idea.

twiecki avatar May 02 '24 20:05 twiecki

can it be related to https://github.com/executablebooks/MyST-NB/pull/588?

juanitorduz avatar May 03 '24 07:05 juanitorduz

mmmm when I build the docs locally make html it works with myst_nb == 1.0 so, when the PR above has not merged ...

juanitorduz avatar May 03 '24 07:05 juanitorduz

Here is a quick fix https://github.com/pymc-labs/pymc-marketing/pull/667 . We might need a better solution. I think one has to tweak the nb_cell_metadata_key, but I did not manage to do it :(

juanitorduz avatar May 03 '24 07:05 juanitorduz

I will re-open this issue as the fix in https://github.com/pymc-labs/pymc-marketing/pull/667 should not be final as we do not want to restrict the versions :)

juanitorduz avatar May 03 '24 11:05 juanitorduz