pymc icon indicating copy to clipboard operation
pymc copied to clipboard

seed flaky test GARCH11::test_batched_size

Open nataziel opened this issue 9 months ago • 3 comments

seed flaky test GARCH11::test_batched_size

Description

TestGARCH11::test_batched_size is flaky in CI, seeded previously non-deterministic rng function.

Related Issue

  • [x] Closes #7674
  • [x] Related to #7684 (alternative solution, should credit the author of that PR also)

Checklist

  • [x] Checked that the pre-commit linting/style checks pass
  • [x] Included tests that prove the fix is effective or that the new feature works
  • [x] Added necessary documentation (docstrings and/or example notebooks)
  • [x] If you are a pro: each commit corresponds to a [relevant logical change

Type of change

  • [ ] New feature / enhancement
  • [x] Bug fix
  • [ ] Documentation
  • [x] Maintenance
  • [ ] Other (please specify):

📚 Documentation preview 📚: https://pymc--7708.org.readthedocs.build/en/7708/

nataziel avatar Mar 03 '25 05:03 nataziel

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.67%. Comparing base (d1aff0b) to head (7b76f67). Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7708   +/-   ##
=======================================
  Coverage   92.67%   92.67%           
=======================================
  Files         107      107           
  Lines       18319    18319           
=======================================
  Hits        16977    16977           
  Misses       1342     1342           

codecov[bot] avatar Mar 03 '25 05:03 codecov[bot]

Did you confirm the things being tested are now deterministic over multiple runs, or is there something else causing stochasticity?

ricardoV94 avatar Mar 03 '25 07:03 ricardoV94

Did you confirm the things being tested are now deterministic over multiple runs, or is there something else causing stochasticity?

I did not yet as I don't have an easy way of running the tests setup on my local machine. I can't see any other places creating randomness within this functional scope, but I'll have a crack at getting the tests running in a container locally to confirm

nataziel avatar Mar 03 '25 07:03 nataziel