pymc icon indicating copy to clipboard operation
pymc copied to clipboard

First time congratulatory message images are huge

Open ricardoV94 opened this issue 1 year ago • 8 comments

Description

https://raw.githubusercontent.com/pymc-devs/brand/main/welcome-bot/BannerCongratulations.jpg https://raw.githubusercontent.com/pymc-devs/brand/main/welcome-bot/BannerThanks.jpg

I don't think we need 3634*1930 pixels to say congrats

ricardoV94 avatar May 17 '24 09:05 ricardoV94

You're probably right.

twiecki avatar May 17 '24 09:05 twiecki

Hi! I just had a quick go at it with ImageMagick.

$ identify BannerCongratulations*
BannerCongratulations.jpg JPEG 3634x1930 3634x1930+0+0 8-bit sRGB 466734B 0.000u 0:00.000
BannerCongratulations_resized_1815.jpg JPEG 1815x964 1815x964+0+0 8-bit sRGB 155276B 0.000u 0:00.000
BannerCongratulations_resized_910.jpg JPEG 910x483 910x483+0+0 8-bit sRGB 65279B 0.000u 0:00.000
$ identify BannerThanks*
BannerThanks.jpg JPEG 3634x1930 3634x1930+0+0 8-bit sRGB 637049B 0.000u 0:00.000
BannerThanks_resized_1815.jpg JPEG 1815x964 1815x964+0+0 8-bit sRGB 206000B 0.000u 0:00.000
BannerThanks_resized_910.jpg JPEG 910x483 910x483+0+0 8-bit sRGB 79989B 0.000u 0:00.000

I did the resize on the width and let ImageMagick figure out the rest. Not sure if you have a strong preference between 1815 or 910 or have another size in mind, but if you let me know I am happy to raise a PR in pymc-devs/brand. In my opinion 910x483 is more than enough.

I think it would be just easier to make the change in a single place (replace the older, bigger image with the new, smaller one but keep the filename) unless you want to keep the original and the resized images with a suffix in the name (in which case changes will also be needed in config.yml).

Examples of different sizes (right-click and open in a new tab): 910 BannerCongratulations_resized_910

1815 BannerCongratulations_resized_1815

And finally, the code :smile:

convert -resize 1815x BannerCongratulations.jpg -quality 90 BannerCongratulations_resized_1815.jpg

markgreene74 avatar Jun 28 '24 10:06 markgreene74

I would also like to suggest to apply the same changes to BannerWelcome.jpg, which has a similar size at the moment.

markgreene74 avatar Jun 28 '24 10:06 markgreene74

Thanks @markgreene74 yes the smaller size and both pictures make sense!

ricardoV94 avatar Jun 28 '24 10:06 ricardoV94

hi @ricardoV94 just want to be sure I understand correctly :smile:

both pictures make sense!

So keep both pictures (the original and the resized version) in pymc-devs/brand and make changes to config.yml so that the resized version is used from now on?

markgreene74 avatar Jun 28 '24 13:06 markgreene74

I don't think we need to keep the original, it exists elsewhere?

ricardoV94 avatar Jun 28 '24 16:06 ricardoV94

I don't think we need to keep the original, it exists elsewhere?

Sorry, I wasn't sure which way you preferred :smile: I will make the changes to https://github.com/pymc-devs/brand/pull/29 now and close #7394

markgreene74 avatar Jun 28 '24 19:06 markgreene74

@ricardoV94 Is the larger image size impacting CI/CD or other items?

If yes, this will help to know because these images are used in various other GitHub organizations.

reshamas avatar Jun 28 '24 23:06 reshamas

As https://github.com/pymc-devs/brand/pull/29 has been merged I think this issue can be closed now? I just had a quick look at one of the PRs using the banners and the new size looks ok.

markgreene74 avatar Jul 04 '24 00:07 markgreene74

@ricardoV94 Is the larger image size impacting CI/CD or other items?

If yes, this will help to know because these images are used in various other GitHub organizations.

I don't think it impacts CI/CD. It could impact email storage, if the pictures are actually sent, but I think only the link. It mostly bothered me because it was rather large when scrolling through issues

ricardoV94 avatar Jul 04 '24 08:07 ricardoV94