pymc icon indicating copy to clipboard operation
pymc copied to clipboard

Reenable some compiler errors

Open maresb opened this issue 1 year ago • 2 comments

Ideally we fix issues instead of suppressing them

Description

I'm hoping that https://github.com/pymc-devs/pytensor/pull/725 will make this flag unnecessary. Looking forward to seeing what happens.

Related Issue

  • [ ] Closes #
  • [ ] Related to #

Checklist

Type of change

  • [ ] New feature / enhancement
  • [ ] Bug fix
  • [ ] Documentation
  • [ ] Maintenance
  • [ ] Other (please specify):

📚 Documentation preview 📚: https://pymc--7270.org.readthedocs.build/en/7270/

maresb avatar Apr 21 '24 16:04 maresb

@ricardoV94, it seems to me like we're missing these upstream macos failures since the PyTensor test suite doesn't run on macos. Any particular reason it's absent? Seems like it would be prudent to add.

maresb avatar Apr 22 '24 07:04 maresb

@ricardoV94, it seems to me like we're missing these upstream macos failures since the PyTensor test suite doesn't run on macos. Any particular reason it's absent? Seems like it would be prudent to add.

We have refrained from duplicating the whole test suite across different OSes because it's pretty wasteful. But we can add other OS jobs with targeted tests. The hard part is just picking what to select

ricardoV94 avatar Apr 22 '24 07:04 ricardoV94