pymc icon indicating copy to clipboard operation
pymc copied to clipboard

added icdf for asymmetric laplace distribution

Open ParamThakkar123 opened this issue 1 year ago • 6 comments

Description

Added icdf function for Asymmetric Laplace distribution

Related Issue

  • [ ] Closes
  • [ ] Related to #6612

Checklist

Type of change

  • [x] New feature / enhancement
  • [ ] Bug fix
  • [ ] Documentation
  • [ ] Maintenance
  • [ ] Other (please specify):

📚 Documentation preview 📚: https://pymc--7141.org.readthedocs.build/en/7141/

ParamThakkar123 avatar Feb 06 '24 16:02 ParamThakkar123

@larryshamalama please take a look at my pull request

ParamThakkar123 avatar Feb 06 '24 16:02 ParamThakkar123

Are there any changes needed to be done ?

ParamThakkar123 avatar Feb 06 '24 16:02 ParamThakkar123

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7bb2ccd) 92.21% compared to head (17338f6) 71.34%. Report is 31 commits behind head on main.

:exclamation: Current head 17338f6 differs from pull request most recent head bb312a8. Consider uploading reports for the commit bb312a8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #7141       +/-   ##
===========================================
- Coverage   92.21%   71.34%   -20.87%     
===========================================
  Files         101      101               
  Lines       16912    16967       +55     
===========================================
- Hits        15595    12105     -3490     
- Misses       1317     4862     +3545     
Files Coverage Δ
pymc/distributions/continuous.py 64.36% <50.00%> (-33.43%) :arrow_down:

... and 82 files with indirect coverage changes

codecov[bot] avatar Feb 06 '24 17:02 codecov[bot]

@larryshamalama I made the changes.

ParamThakkar123 avatar Feb 07 '24 02:02 ParamThakkar123

Have you checked if the test passes locally? That would be an indication, good or bad, if you are on the right track

larryshamalama avatar Feb 07 '24 15:02 larryshamalama

@ricardoV94 I changed the if else conditions in python to pytensor condition

ParamThakkar123 avatar Feb 12 '24 13:02 ParamThakkar123