added icdf for asymmetric laplace distribution
Description
Added icdf function for Asymmetric Laplace distribution
Related Issue
- [ ] Closes
- [ ] Related to #6612
Checklist
- [ ] Checked that the pre-commit linting/style checks pass
- [ ] Included tests that prove the fix is effective or that the new feature works
- [ ] Added necessary documentation (docstrings and/or example notebooks)
- [ ] If you are a pro: each commit corresponds to a relevant logical change
Type of change
- [x] New feature / enhancement
- [ ] Bug fix
- [ ] Documentation
- [ ] Maintenance
- [ ] Other (please specify):
📚 Documentation preview 📚: https://pymc--7141.org.readthedocs.build/en/7141/
@larryshamalama please take a look at my pull request
Are there any changes needed to be done ?
Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.
Comparison is base (
7bb2ccd) 92.21% compared to head (17338f6) 71.34%. Report is 31 commits behind head on main.
:exclamation: Current head 17338f6 differs from pull request most recent head bb312a8. Consider uploading reports for the commit bb312a8 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #7141 +/- ##
===========================================
- Coverage 92.21% 71.34% -20.87%
===========================================
Files 101 101
Lines 16912 16967 +55
===========================================
- Hits 15595 12105 -3490
- Misses 1317 4862 +3545
| Files | Coverage Δ | |
|---|---|---|
| pymc/distributions/continuous.py | 64.36% <50.00%> (-33.43%) |
:arrow_down: |
@larryshamalama I made the changes.
Have you checked if the test passes locally? That would be an indication, good or bad, if you are on the right track
@ricardoV94 I changed the if else conditions in python to pytensor condition