pymc icon indicating copy to clipboard operation
pymc copied to clipboard

Adding add_coords function

Open zaxtax opened this issue 2 years ago • 3 comments

This adds the add_coords function so that coords can be updated without needing to explicitly mentioning a model

Checklist

New features

  • Add a new function

:books: Documentation preview :books:: https://pymc--7037.org.readthedocs.build/en/7037/

zaxtax avatar Nov 28 '23 14:11 zaxtax

Codecov Report

Merging #7037 (58c03e8) into main (915e6a2) will increase coverage by 0.00%. The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7037   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files         101      101           
  Lines       16827    16830    +3     
=======================================
+ Hits        15509    15512    +3     
  Misses       1318     1318           
Files Coverage Δ
pymc/model/core.py 91.78% <100.00%> (+0.03%) :arrow_up:

codecov[bot] avatar Nov 28 '23 14:11 codecov[bot]

Would something that can also update existing coords be more useful? Perhaps named set_coords?

ricardoV94 avatar Nov 28 '23 17:11 ricardoV94

Would something that can also update existing coords be more useful? Perhaps named set_coords?

Maybe, but updating coords likely would require something like the tricky shape-checking logic in set_data. Is there a use-case you have in mind for set_coords?

zaxtax avatar Nov 28 '23 17:11 zaxtax