pymc icon indicating copy to clipboard operation
pymc copied to clipboard

Deprecate SumTo1 Transform

Open ricardoV94 opened this issue 2 years ago • 8 comments

Description

This seems to be an old transform that was replaced by the Simplex transform.

ricardoV94 avatar Nov 14 '23 08:11 ricardoV94

i want to work on this issue .

PulsatingGenius avatar Nov 22 '23 17:11 PulsatingGenius

@PulsatingGenius Great, just open a PR (can be draft too).

twiecki avatar Nov 22 '23 22:11 twiecki

Hello if this issue is not currently being worked on I would like to work on it. I was wondering what needs to be included in a draft pull request?

nyeshlur avatar Dec 10 '23 04:12 nyeshlur

For now just a FutureWarning when users access the transform to let them know it's deprecated and will be removed in the future

Plus a test that verified the warning is working but you can still access it

ricardoV94 avatar Dec 10 '23 08:12 ricardoV94

Hi so I have created a FutureWarning in pymc/distributions/transforms.py and I have written a test in tests/distributions/test_transform.py. I'm not sure if this is what is needed and I'm also unsure of how to run the test. Any help is appreciated.

nyeshlur avatar Dec 13 '23 20:12 nyeshlur

Thanks, I'll take a look but in the meantime this may give you some hints: https://www.pymc.io/projects/docs/en/stable/contributing/running_the_test_suite.html

ricardoV94 avatar Dec 13 '23 20:12 ricardoV94