pymc icon indicating copy to clipboard operation
pymc copied to clipboard

Stop squeezing stats by default

Open michaelosthege opened this issue 3 years ago • 3 comments

Squeezing stats by default removes the "stepmethod" dimension (which we don't name explicitly), but this does not always work for object-dtyped stats.

This is (very often) the case for the "warning" stat introduced by #6192, but also for stats that have varying shape.

We should probably not only stop squeezing, but instead unpack stats into a long form, such that there is not even a stepmeethod dimension. This is how McBackend stores stats, because it works for any (hierarchical) combination of step methods.

michaelosthege avatar Oct 11 '22 22:10 michaelosthege

I think we have already done this, feel free to reopen if I am mistaken

ricardoV94 avatar Dec 15 '23 10:12 ricardoV94

No, it's still there: https://github.com/pymc-devs/pymc/blob/904a0eaac216732bc358dd91680cd428d95704f0/pymc/backends/base.py#L533

I was the last one to edit that file (7 months ago)

michaelosthege avatar Dec 15 '23 17:12 michaelosthege

I was thinking of this https://github.com/pymc-devs/pymc/commit/8ea8b3b6c2ceb67b964478783049888bb2ce44c1

ricardoV94 avatar Dec 15 '23 20:12 ricardoV94