pymc
pymc copied to clipboard
Consider removing old shape handling functions
Now that random draws are done by Aesara, we might not need some/all of these anymore:
https://github.com/pymc-devs/pymc/blob/761f77dad29116650ef3ca043645042219654a5c/pymc/distributions/shape_utils.py#L38-L42
First step would be to check which ones are still used and where.
As far as I can say,
shapes_broadcastingis only used inbroadcast_dist_samples_shapeandget_broadcastable_dist_samples,broadcast_dist_samples_shapeis only used inget_broadcastable_dist_samples,get_broadcastable_dist_samplesis only used inbroadcast_distribution_samplesandbroadcast_dist_samples_to,broadcast_distribution_samplesis not used anywhere,broadcast_dist_samples_tois the only of these functions used somewhere else in the code, and only inMatrixNormalRV.
So we should check if we can get something more immediate to replace broadcast_dist_samples_to in MatrixNormalRV? I haven't looked at what it is doing
Is this still an open issue? I am interested in working on it