profiling

[OriolAbril]

File: https://github.com/pymc-devs/pymc-examples/blob/main/examples/pymc3_howto/profiling.ipynb Reviewers:

The sections below may still be pending. If so, the issue is still available, it simply doesn't have specific guidance yet. Please refer to this overview of updates

Known changes needed

Changes listed in this section should all be done at some point in order to get this notebook to a "Best Practices" state. However, these are probably not enough! Make sure to thoroughly review the notebook and search for other updates.

General updates

• random global seeding is not used and should be removed
• theano should be in the watermark list of versions

ArviZ related

None

Notes

Exotic dependencies

None

Computing requirements

No special requirements

[digitalsimboja]

Hi Oriol,

Please clarify so I can raise a PR, the solution is to find random seeding and removed and then add theano to the watermark list of versions?

Regards

[OriolAbril]

I have already gone over the notebook and classified it in the "ArviZ" column. Therefore you have to make sure that all the recommendations in the section "General updates" of notebook update overview are met and that the notebook follows the notebook style guide in order to improve the notebook. After that, I will move it to the "Best practices" column of the tracker.

In this specific case, we are note generating random samples, so there is no need to set the random seed with np.random.seed, and this notebook uses theano extensively but doesn't have which theano version it used to run. This should be included in the last cell by the watermark package as explained in the style guide I linked above.

You should also give a quick read to the contributing guide to see the differences between contributing to pymc3 here and contributing here.

[digitalsimboja]

Thanks for this

Thanks and regards

On Apr 5, 2021 5:11 PM, "Oriol Abril-Pla" @.***> wrote:

I have already gone over the notebook and classified it in the "ArviZ" column. Therefore you have to make sure that all the recommendations in the section "General updates" of notebook update overview https://github.com/pymc-devs/pymc-examples/wiki/Notebook-updates-overview are met and that the notebook follows the notebook style guide https://github.com/pymc-devs/pymc3/wiki/PyMC3-Jupyter-Notebook-Style-Guide in order to improve the notebook. After that, I will move it to the "Best practices" column of the tracker https://github.com/pymc-devs/pymc-examples/projects/1.

In this specific case, we are note generating random samples, so there is no need to set the random seed with np.random.seed, and this notebook uses theano extensively but doesn't have which theano version it used to run. This should be included in the last cell by the watermark package as explained in the style guide I linked above.

You should also give a quick read to the contributing guide https://github.com/pymc-devs/pymc-examples/blob/main/CONTRIBUTING.md to see the differences between contributing to pymc3 here and contributing here.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pymc-devs/pymc-examples/issues/111#issuecomment-813477084, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHUTWR3BRQGZXKNU3MYAJYTTHHOKPANCNFSM42L67WYA .