pylint icon indicating copy to clipboard operation
pylint copied to clipboard

(proposal) Always use the suggestion mode for ``no-member`` / ``c-extension-no-member``

Open Pierre-Sassoulas opened this issue 1 year ago â€Ē 2 comments

Type of Changes

Type
✓ :hammer: Refactoring

Description

Work in progress to know what others think. There's no reason to add to not suggest imo (?), so we can remove the option too in the spirit of simplification.

Pierre-Sassoulas avatar Sep 24 '24 15:09 Pierre-Sassoulas

ðŸĪ– According to the primer, this change has no effect on the checked open source code. ðŸĪ–🎉

This comment was generated for commit b37036321850cf6732cb1f4cdb66a0249f1ada80

github-actions[bot] avatar Sep 24 '24 15:09 github-actions[bot]

ðŸĪ– According to the primer, this change has no effect on the checked open source code. ðŸĪ–🎉

This comment was generated for commit 7a7170f3d2fc2e608a6ed3acc31ead9d787d36e7

github-actions[bot] avatar Oct 14 '24 20:10 github-actions[bot]

ðŸĪ– According to the primer, this change has no effect on the checked open source code. ðŸĪ–🎉

This comment was generated for commit 8e103a6b98a6046bb6984729a3af5482605aadf5

github-actions[bot] avatar Dec 01 '24 20:12 github-actions[bot]

ðŸĪ– According to the primer, this change has no effect on the checked open source code. ðŸĪ–🎉

This comment was generated for commit 17a9dcac160a3e0eb510a619caeddf2f70f17b1a

github-actions[bot] avatar Dec 01 '24 22:12 github-actions[bot]

ðŸĪ– According to the primer, this change has no effect on the checked open source code. ðŸĪ–🎉

This comment was generated for commit d2abf8d262fb3050ebe42266c756449eb064c707

github-actions[bot] avatar Dec 02 '24 08:12 github-actions[bot]

ðŸĪ– According to the primer, this change has no effect on the checked open source code. ðŸĪ–🎉

This comment was generated for commit bf2fcc782cdee7a5f5dab432df65d5c57298452c

github-actions[bot] avatar Mar 30 '25 11:03 github-actions[bot]

ðŸĪ– Effect of this PR on checked open source code: ðŸĪ–

Effect on home-assistant: The following messages are now emitted:

  1. logging-too-few-args: Not enough arguments for logging format string https://github.com/home-assistant/core/blob/09f6246d1b7693393332535866e02fb203fb689d/homeassistant/components/homeworks/config_flow.py#L175
  2. logging-too-few-args: Not enough arguments for logging format string https://github.com/home-assistant/core/blob/09f6246d1b7693393332535866e02fb203fb689d/homeassistant/components/shopping_list/init.py#L242
  3. logging-too-few-args: Not enough arguments for logging format string https://github.com/home-assistant/core/blob/09f6246d1b7693393332535866e02fb203fb689d/homeassistant/components/snoo/config_flow.py#L53
  4. logging-too-few-args: Not enough arguments for logging format string https://github.com/home-assistant/core/blob/09f6246d1b7693393332535866e02fb203fb689d/homeassistant/components/sisyphus/light.py#L88
  5. logging-too-few-args: Not enough arguments for logging format string https://github.com/home-assistant/core/blob/09f6246d1b7693393332535866e02fb203fb689d/homeassistant/components/sisyphus/light.py#L94

This comment was generated for commit 32b7046131805a02d0137ec5edc9feaeeffd29e3

github-actions[bot] avatar Mar 30 '25 16:03 github-actions[bot]

Blocked by #10320

Pierre-Sassoulas avatar Mar 30 '25 16:03 Pierre-Sassoulas

(I won't be able to work on this caching issue for the next 3 days as I'll be on mobile.)

Pierre-Sassoulas avatar Mar 30 '25 19:03 Pierre-Sassoulas

Is this a caching issue? Isn't it just a test failure?

DanielNoord avatar Mar 30 '25 19:03 DanielNoord

The failing test is test_generate_rcfile nothing happens locally if I try to regenerate the rc file. (The error message is horrendous, I could try to make it more like the message when the doc is not up to date)

Pierre-Sassoulas avatar Mar 30 '25 20:03 Pierre-Sassoulas

ðŸĪ– According to the primer, this change has no effect on the checked open source code. ðŸĪ–🎉

This comment was generated for commit 87c6d0cc2fe0bb4ac39042abc2394d285450ba45

github-actions[bot] avatar Mar 30 '25 20:03 github-actions[bot]

ðŸĪ– According to the primer, this change has no effect on the checked open source code. ðŸĪ–🎉

This comment was generated for commit 8eb2dbf2d597e58e9f6926b1d49a3f3a4f4e87f5

github-actions[bot] avatar Mar 30 '25 21:03 github-actions[bot]

@Pierre-Sassoulas Both main and https://github.com/pylint-dev/pylint/pull/10287 failed on the same error in PyPy. Considering it failed when we tried to add it and I really don't think there is a lot of value of supporting PyPy: at what point we do just declare it unmaintained?

DanielNoord avatar Mar 30 '25 21:03 DanielNoord

We're already skipping some tests on pypi, we can skip more. There seem to be some users as evidenced by the MR opened to add 3.11 pypy support you linked.

Pierre-Sassoulas avatar Apr 01 '25 20:04 Pierre-Sassoulas