pylint
pylint copied to clipboard
pylint-dev
no need to complain 'attribute-defined-outside-init' when base class not in same file as sub class
Steps to reproduce
from m import BaseA
class A(BaseA):
def load(self, x):
self.x = x
Current behavior
/tmp/3.py:7: [W0201(attribute-defined-outside-init), A.load] Attribute 'x' defined outside __init__
Expected behavior
In this module, the pylint would complain 'attribute-defined-outside-init' since it does not found self.x defined in __init__. But the fact is that self.x MAY have already been defined in base class BaseA in different module m.py.
To my understanding, pylint should not complain such indeterminacy.
pylint --version output
Using config file $PATH_TO_pylintrc pylint 1.9.5, astroid 1.6.6 Python 2.7.10 (default, Aug 17 2018, 17:41:52) [GCC 4.2.1 Compatible Apple LLVM 10.0.0 (clang-1000.0.42)]
After a quick check it seems pylint does not emit this when the base class is importable and the attribute is defined in __init__. But it still emits the error if the base class cannot be found or inferred. We should change the behaviour of the latter.
Also shows up if the init() for class BaseA calls something like self.initialize() and you try to initialize vars for the subclass in that subclass.
We're not maintaining pylint 1.9 anymore. In the latest pylint, with:
a.py:
from m import BaseA
class A(BaseA):
def load(self, x):
self.x = x
And m.py:
class BaseA:
def __init__(self):
self.x = 1
We do not get any attribute-defined-outside-init as expected.
Also shows up if the init() for class BaseA calls something like self.initialize() and you try to initialize vars for the subclass in that subclass.
If you're using a function called initialize or ìnit, consider initializing in the function that is semantically the constructor in python (__init__) or disable the warning for your project or the class.
@Pierre-Sassoulas The latest version pylint at the time of my comment (v2.17.5) seems to have reintroduced this bug, as I am getting the attribute-defined-outside-init error using exactly the example code provided.
Please see the attached 10 second video for a demo. Can we reopen this issue?
https://github.com/pylint-dev/pylint/assets/124291546/3a28f7e1-2554-4690-abef-9e16d8ed419a
Hello, the latest version of pylint is 3.0.0a7, would you mind testing after upgrading ?
Hello, the latest version of pylint is 3.0.0a7, would you mind testing after upgrading ?
Hi @Pierre-Sassoulas and thanks for your quick reply!
Yes, the error/bug still occurs on version 3.0.0a7, as shown in the video below.
https://github.com/pylint-dev/pylint/assets/124291546/d784b148-fca8-43c8-8ccd-89a46b324954
